Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor for heat meter #1833

Merged
merged 8 commits into from
Feb 12, 2024
Merged

Add sensor for heat meter #1833

merged 8 commits into from
Feb 12, 2024

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Feb 1, 2024

This closes #1831

JAG-1337 and others added 5 commits February 1, 2024 15:32
Renamed input, added annotations, changed example, added documentation of example
@mwetter mwetter requested a review from amaccarini February 1, 2024 22:53
Copy link
Contributor

@amaccarini amaccarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

@JAG-1337
Copy link
Contributor

JAG-1337 commented Feb 6, 2024

Thanks for mentioning me in the contributor list, @mwetter! Would you mind to change the company name to Robert Bosch GmbH?

@mwetter
Copy link
Contributor Author

mwetter commented Feb 6, 2024

@JAG-1337 : Sure, I updated it and will merge when the tests pass.

@mwetter mwetter merged commit e70093d into master Feb 12, 2024
3 checks passed
@mwetter mwetter deleted the issue1831_heatMeter branch February 12, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HeatMeter as sensor
3 participants